Monday, May 14, 2018 10:36 AM, Andrew Rybchenko: > Subject: [PATCH v2 0/3] ethdev: fail if requested offload is not supported > > The series has fixes for problems discussed in [1]. > > Basically it does not allow unsupported offloads to pass. > > If fixes regressions for PMDs which carefully check offloads before, but these > checks are removed now in favor of checks in ethdev. > > It may break applications which request some offload which is not supported > by underlying PMD, but does not actually used. > > Depending on discussion results it should be either dropped or applied. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2018- > May%2F101261.html&data=02%7C01%7Cshahafs%40mellanox.com%7C9a572 > e9d86b04c99854c08d5b96d75b5%7Ca652971c7d2e4d9ba6a4d149256f461b%7 > C0%7C0%7C636618802134607945&sdata=fQKCr%2FrFvakWVIFomy8iSD%2Bc > VtSie8mvgx63Qqgq690%3D&reserved=0 > > v1 -> v2: > - use IGNORE flag to separate old and new offload API cases on > Tx queue setup and avoid expected errors if old API is used > as suggested by Shahaf > - remove convertion of rxmode bits on Rx queue setup since exactly > these bits are removed > > Andrew Rybchenko (3): > ethdev: fail configure if requested offload is not supported > ethdev: fail if Tx queue offload is not supported > ethdev: fail if Rx queue offload is not supported > > lib/librte_ethdev/rte_ethdev.c | 62 +++++++++++++++++++--------------- > 1 file changed, 35 insertions(+), 27 deletions(-)
For the series - Acked-by: Shahaf Shuler <shah...@mellanox.com> > > -- > 2.17.0
