Re: [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length

[Andrew Rybchenko]

On 05/11/2018 04:46 AM, Andy Green wrote:

Signed-off-by: Andy Green <a...@warmcat.com>
---
  drivers/net/sfc/sfc_ethdev.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index e42d55350..ef5e9ecb2 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -13,6 +13,7 @@
  #include <rte_pci.h>
  #include <rte_bus_pci.h>
  #include <rte_errno.h>
+#include <rte_string_fns.h>

#include "efx.h" @@ -741,9 +742,8 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,

                if ((ids == NULL) || (ids[nb_written] == nb_supported)) {
                        char *name = xstats_names[nb_written++].name;

- strncpy(name, efx_mac_stat_name(sa->nic, i),

+                       strlcpy(name, efx_mac_stat_name(sa->nic, i),
                                sizeof(xstats_names[0].name));
-                       name[sizeof(xstats_names[0].name) - 1] = '\0';
                }

++nb_supported;

Acked-by: Andrew Rybchenko <arybche...@oktetlabs.ru>