> -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, September 08, 2014 1:33 PM > To: Richardson, Bruce; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/6] Mbuf structure Rework, part 1 > > Hi Bruce, > > On 08/27/2014 05:50 PM, Bruce Richardson wrote: > > This patch set does some initial pre-work to prepare the mbuf data structure > > (and ixgbe vector driver to a lesser extent) for more major changes which > > will follow on in a subsequent patch set. [See previous RFC patch set for > > more indications of the future coming changes]. > > > > The main changes here are the flattening out of the mbuf data structure, > > with > > much of it based off work by Olivier. The ctrlmbuf and pktmbuf structures > > are > > now gone, as is the vlan_macip structure. However, in this set, the concept > > of having a separate ctrl mbuf type is kept around. The plan is in a later > > set > > when we expand the flags field to 64-bits, we can use a single bit in the > > flags > > to indicate a control packet. For now, though, the ctrlmbuf functions and > macros > > just are aliases for the pktmbuf equivalents as much as possible. > > I'm wondering it "struct rte_kni_mbuf" should be updated > accordingly each time "struct mbuf" is modified. > > Regards, > Olivier
Yes, it should. There are no changes needed for the part 1 patch set (6 patches), as it does not change the actual field layout, it just flattens the C definitions. I've already started working on an update to the second patch set (13 patches) including kni changes as part of it. /Bruce
