> -----Original Message----- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Sunday, May 6, 2018 2:22 AM > To: Xu, Rosen <rosen...@intel.com>; dev@dpdk.org > Cc: Doherty, Declan <declan.dohe...@intel.com>; Richardson, Bruce > <bruce.richard...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; > Ananyev, Konstantin <konstantin.anan...@intel.com>; Zhang, Tianfei > <tianfei.zh...@intel.com>; Liu, Song <song....@intel.com>; Wu, Hao > <hao...@intel.com>; gaetan.ri...@6wind.com > Subject: RE: [PATCH v7 4/5] iFPGA: add meson build > > > -----Original Message----- > > From: Xu, Rosen [mailto:rosen...@intel.com] > > Sent: Friday, May 4, 2018 7:41 PM > > To: dev@dpdk.org > > Cc: rosen...@intel.com; declan.dohe...@intel.com; > > bruce.richard...@intel.com; Shreyansh Jain <shreyansh.j...@nxp.com>; > > ferruh.yi...@intel.com; konstantin.anan...@intel.com; > > tianfei.zh...@intel.com; song....@intel.com; hao...@intel.com; > > gaetan.ri...@6wind.com > > Subject: [PATCH v7 4/5] iFPGA: add meson build > > > > [...] > > > index 0000000..6725687 > > --- /dev/null > > +++ b/drivers/raw/ifpga_rawdev/meson.build > > @@ -0,0 +1,15 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel > > +Corporation > > + > > +version = 1 > > + > > +subdir('base') > > +objs = [base_objs] > > + > > +deps += ['rawdev', 'pci', 'bus_pci', 'kvargs', > > + 'bus_vdev', 'bus_ifpga'] > > +sources = files('ifpga_rawdev.c') > > + > > +includes += include_directories('base') > > + > > +allow_experimental_apis = true > > diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build new > > file mode 100644 index 0000000..410f908 > > --- /dev/null > > +++ b/drivers/raw/meson.build > > @@ -0,0 +1,6 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel > > +Corporation > > + > > +drivers = ['ifpga_rawdev'] > > +config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' > > +driver_name_fmt = 'rte_@0@' > > I think you missed this again. From [1], you were to base your patch over > cmdif so that this drivers/raw/meson.build introduction doesn't conflict. > > Can you rebase and send once again, but *only* once cmdif patches have > been merged? > > [1] http://dpdk.org/ml/archives/dev/2018-May/100064.html
Oh, we will modify it and send the v8 patches today.
