> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 22, 2014 5:25 PM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of > VxLAN filter > > 2014-10-22 06:45, Liu, Jijiang: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2014-10-21 16:46, Jijiang Liu: > > > > +#define RTE_TUNNEL_FILTER_TO_QUEUE 1 /**< point to an queue by > > > > +filter > > > type */ > > > > > > Sorry, I don't understand what is this value for? > > > > This MACRO is used to indicate if user application hope to filter > > incoming packet(s) to a specific queue(multi-queue configuration is > > required) using filter type(such as inner MAC + tenant ID). > > If the flag is not set, and all incoming packet will always go to > > queue 0. > > 1) It's a boolean, so a new constant is not required. OK. define bool to_queue. > 2) You set the variable "to_queue" with this value but the variable is not > used > 3) Is there a sense to add a filter with this variable to 0? > > I think "to_queue" variable and this constant are useless. No, It is useful. I will change to_queue to be configurable. > PS: it seems I'm the only person worried by the filtering API. > So maybe we shouldn't integrate it at all?
I know you are joking. We should certainly integrate the feature into dpdk.org > -- > Thomas
