> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, October 21, 2014 10:12 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] librte_ip_frag: Disable ipv4/v6 > fragmentation if RTE_MBUF_REFCNT=n > > 2014-10-21 15:15, Pablo de Lara: > > Ipv4/v6 fragmentation libraries depends on refcnt. > > There was a compilation error if RTE_MBUF_REFCNT was disabled, > > so those libraries have been disabled in that situation. > > Please Pablo, could you add a short justification that it's not > possible to implement fragmentation without refcnt (at least with > the current design)?
Will send a v2 with it. > > What do you think of adding a warning as below? > > > +ifeq ($(CONFIG_RTE_MBUF_REFCNT),y) > > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_fragmentation.c > > -SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c > > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv6_fragmentation.c > +else > +$(info WARNING: Fragmentation feature is disabled because it needs > MBUF_REFCNT.) > > +endif > > +SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c Good idea. Thanks Thomas! > > -- > Thomas
