> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, October 10, 2014 12:14 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to > include default RX/TX configuration > > Pablo, I have some minor nits on this patchset. > If you agree, I can fix them before applying the patchset.
Sure, those changes seem reasonable. Many thanks, Pablo > > 2014-10-01 10:49, Pablo de Lara: > > +/** > > + * Default values for port configuration > > + */ > > +#define IGB_DEFAULT_RX_FREE_THRESH 32 > > +#define IGB_DEFAULT_RX_PTHRESH 8 > > +#define IGB_DEFAULT_RX_HTHRESH 8 > > +#define IGB_DEFAULT_RX_WTHRESH 0 > > + > > +#define IGB_DEFAULT_TX_PTHRESH 32 > > +#define IGB_DEFAULT_TX_HTHRESH 0 > > +#define IGB_DEFAULT_TX_WTHRESH 0 > > Comments in .c files are not for doxygen. So /** should be replaced by /* > > > static int eth_igb_get_5tuple_filter(struct rte_eth_dev *dev, > > uint16_t index, > > struct rte_5tuple_filter *filter, uint16_t *rx_queue); > > - > > /* > > * Define VF Stats MACRO for Non "cleared on read" register > > */ > > This blank line shouldn't be removed. Probably a typo? > > -- > Thomas
