On Tue, Oct 07, 2014 at 05:14:05PM +0200, Thomas Monjalon wrote: > Hi Ouyang, > > 2014-09-29 15:16, Ouyang Changchun: > > This patch series update IXGBE base code (a.k.a. share code) from > > package 2014.03.13 to package 2014.09.04 > > Applied > > You did a big work to split patches and I did another big work > to split all features and to make each commit compile-able > (with a minor exception). > As Neil asked, some comments are missing. But I push these commits > as is because base drivers are special and it's already a good improvement > since the last update submission. > I'm confident that the next one will be even better in comments and splitting. >
Why would you do that? I don't see any reasoning behind why base drivers are "special" here. I had legitimate unanswered questions regarding this series. If you don't think my questions were relevant (specifically the question regarding code reachability), please indicate why its not worth waiting for an answer on. It seems to me like it wouldn't have been a hard question to settle (either explain the reachability path, or remove the code). Having the author ignore the question, and having you integrate the code anyway, is a recepie for promising questions like that never get addressed. Regards Neil
