2014-11-26 10:32, David Marchand: > On Tue, Nov 25, 2014 at 11:17 PM, Chao Zhu <chaozhu at linux.vnet.ibm.com> > wrote: > > > The set of patches add IBM Power architecture to the DPDK. It adds the > > required support to the EAL library. This set of patches doesn't support > > full DPDK function on Power processors. To compile on PPC64 architecture, > > GCC version >= 4.8 must be used. According to Bruce and Neil's comments, > > this v5 patch removed the common configuration files of Powerpc in v4. > > Also, it fixed the checkpatch issues in v3. > > > > The only unsolved checkpatch issue is : > > ERROR: space prohibited before open square bracket '[' > > > > This issue refers to the asm code input/output naming. But I think the > > error is invalid. > > > > > I must admit that the architecture abstraction in dpdk is not fully done, > but it is more a "core" problem than a problem of this port itself. > I am pretty sure that there is still a lot of places in dpdk that rely on > the fact that they were written for x86 architecture. > > Neil's concerns on cpuflags ( > http://dpdk.org/ml/archives/dev/2014-November/008769.html) are valid but I > think we could go with an incremental approach. > Since Chao is commited to add power support to dpdk, we can have this fixed > in subsequent patches with this patchset in 1.8. > > > So, this patchset looks good enough to me. > Acked-by: David Marchand <david.marchand at 6wind.com>
Applied. Nice to see a new architecture. We'll have to make things more generic and do more tests but this is a good first step. Thanks -- Thomas
