2014-11-21 19:36, Thomas Monjalon:
> 2014-11-21 17:07, Doherty, Declan:
> > Hey Thomas, have you had a chance to have a look at this patchset, if you
> > have any comments or issues can you let me know asap, as the patch sets for
> > link bonding modes 4 & 5 are dependent on this set and I don't want to be
> > blocking them from the next release candidate.
>
> Declan, your patchset doesn't touch anything else than the bonding area
> (except socket_id parameter in testpmd), it is acked and it has a test
> report since today.
> You are the author (and implicit maintainer) of bonding, so I consider
> I don't need to review this patchset.
>
> Conclusion: yes, it should be applied shortly.
Actually no, checkpatch says this patchset is not ready.
Some errors:
TYPO_SPELLING: 'interupt' may be misspelled - perhaps 'interrupt'?
TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'?
BRACES: braces {} are not necessary for single statement blocks
SPACING: space prohibited before semicolon
MISSING_SPACE: break quoted strings at a space character
TRAILING_SEMICOLON: macros should not use a trailing semicolon
SPACING: space prohibited after that open parenthesis '('
Please fix and send a v7.
Thanks
--
Thomas
