> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, November 12, 2014 5:31 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant > structures for hash filter control > > 2014-11-12 05:52, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > Actually you use ETH_FLOW_TYPE_IPV4 for ixgbe and > > > ETH_FLOW_TYPE_FRAG_IPV4 or ETH_FLOW_TYPE_NONFRAG_IPV4_* for > i40e. > > > It's not consistent and clearly shows that you stick to the hardware > definitions. > > > > > > Something really generic could be a set of flags like this: > > > IPV4 > > > IPV6 > > > NONFRAG > > > UDP > > > TCP > > > SCTP > > > > Good conclusion! We could think of it in a new patch set. > > I don't want to put everything into this patch. :) > > If you agree flags must be used, the old defines must be removed. > So no need to rename the defines. > I think you should directly change to flags (in this patchset or another). I will keep it as it is in this patch for configuring hash functions. But I really agree with your idea of using flags instead. I will rework it in another patch set and send out a RFC to see if there is any objections. For this patch set, I will focus on feature itself.
> > Thanks > -- > Thomas Regards, Helin
