Hi Thomas, Thanks very much for applying this patch!
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, November 12, 2014 7:17 AM > To: Ouyang, Changchun > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature > > > -V1 change: > > This patch series support multicast feature in virtio and vhost. > > The vhost backend enables the promiscuous mode and config > > ETH_VMDQ_ACCEPT_BROADCAST and ETH_VMDQ_ACCEPT_MULTICAST in > VMDQ offload register to receive the multicast and broadcast packets. > > The virtio frontend provides the functionality of enabling and > > disabling the multicast and promiscuous mode. > > > > -V2 change: > > Rework the patch basing on new vhost library and new vhost application. > > > > -V3 change: > > Rework the patch for comments, split commits. > > > > -V4 change: > > Rework for refining code comment and patch titles, fatorizing codes, and > resolving conflicts. > > > > Changchun Ouyang (5): > > ethdev: Add vmdq rx mode > > igb: Config VM offload register > > ixgbe: Configure Rx mode for VMDQ > > virtio: Support promiscuous and allmulticast > > vhost: Enable promisc mode and multicast > > I reviewed only the first 3 commits. > The virtio and vhost commits seem to have been reviewed by Huawei. > Next times, a clear acked-by would be preferable. > Please note that this is the role of developpers to request reviews when > needed. Reviews are not always spontaneous :) > Yes I have asked some guys more than 3 times to review and ack this patch, Just because each guy has tightly schedule on their own patch rework, doc writing, next feature planning, etc, So the patch-acking delays.. Thanks again and regards, Changchun
