Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, November 6, 2014 9:56 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode > > 2014-10-31 13:19, Ouyang Changchun: > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -577,6 +577,7 @@ struct rte_eth_vmdq_rx_conf { > > uint8_t default_pool; /**< The default pool, if applicable */ > > uint8_t enable_loop_back; /**< Enable VT loop back */ > > uint8_t nb_pool_maps; /**< We can have up to 64 filters/mappings > */ > > + uint32_t rx_mode; /**< RX mode for vmdq */ > > You are adding the field rx_mode in struct rte_eth_vmdq_rx_conf. > So the comment "RX mode for vmdq" is not really informative :) It would be > more interesting to explain which kind of value this field must contain. > Something like "flags from ETH_VMDQ_ACCEPT_*". > Thanks for your comments, I will update it.
Changchun
