Hi Thomas, I planned to, but very unlikely that it would happen that week. Thanks Konstantin
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, May 22, 2014 4:47 PM To: Ananyev, Konstantin Cc: dev at dpdk.org Subject: Re: [dpdk-dev] rte_pktmbuf_alloc fails 2014-04-17 17:00, Thomas Monjalon: > Hi Konstantin, > > 2014-04-07 08:53, Ananyev, Konstantin: > > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf > > corruption. > > I think it should be something like that instead: > > > > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c > > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c > > @@ -205,8 +205,9 @@ eth_pcap_tx(void *queue, > > > > mbuf = bufs[i]; > > ret = pcap_sendpacket(tx_queue->pcap, (u_char*) > > > > mbuf->pkt.data, mbuf->pkt.data_len); > > - if(likely(!ret)) > > - num_tx++; > > + if(unlikely(ret != 0)) > > + break; > > + num_tx++; > > > > rte_pktmbuf_free(mbuf); > > > > } > > Please could you send a patch with a commit log as described in > http://dpdk.org/dev#send ? I think you haven't sent patch for this bug. Do you plan to do so? Thanks -- Thomas
