2014-05-22 11:35, Helin Zhang: > Error of "implicit-function-declaration" can be seen when building KNI > kernel module on Linux kernel 3.6.10 platform, as follows. > "x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > In function \u2018igb_get_eee\u2019: > x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > 2441:4: error: implicit declaration of function > \u2018mmd_eee_adv_to_ethtool_adv_t\u2019 > [-Werror=implicit-function-declaration] > x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > In function \u2018igb_set_eee\u2019: > x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > 2551:2: error: implicit declaration of function > \u2018ethtool_adv_to_mmd_eee_adv_t\u2019 > [-Werror=implicit-function-declaration]" > > The root cause is as follows. > On Fedora 18 with kernel 3.6.10, ETHTOOL_GEEE is defined in Linux > header file of "linux/ethtool.h", while is not defined in most of other > linux kernel versions. > mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and > ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by "#if > !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE <= > RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee() in > igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE". > > Signed-off-by: Helin Zhang <helin.zhang at intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com> Applied for version 1.7.0. Thanks -- Thomas
