Fine, I will split it. -----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Monday, May 19, 2014 6:17 PM To: Wu, Jingjing Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH][PMD][GENERIC_FILTER] add NIC filters support for generic filter feature
Hi Jingjing, 2014-05-17 17:35, Jingjing Wu: > A generic filter mechanism for handling special packet is required. It > will allows filters to be set in HW when available for so that > specific packets may be filtered by NICs to specific desriptor queues for > processing. > Currently only the Flow Director for Intel's 10GbE 82599 devices is > available. Other types of filter are not supported. > > This pacth adds following NIC filters used to assign different packets > to certain receive queues. ethertype filter/syn filter/2tuple > filter/flex filter for E1000(82580, i350) ethertype filter/syn > filter/5tuple filter for > 10G(82599) > > Signed-off-by: jingjing.wu <jingjing.wu at intel.com> > --- > app/test-pmd/cmdline.c | 905 > +++++++++++++++++++++++++++++++++++- app/test-pmd/config.c | > 143 ++++++ > app/test-pmd/testpmd.h | 6 + > lib/librte_ether/rte_ethdev.c | 300 ++++++++++++ > lib/librte_ether/rte_ethdev.h | 429 ++++++++++++++++- > lib/librte_pmd_e1000/e1000_ethdev.h | 38 ++ > lib/librte_pmd_e1000/igb_ethdev.c | 512 ++++++++++++++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 365 +++++++++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 33 ++ > 9 files changed, 2729 insertions(+), 2 deletions(-) It would be really easier to review if you split it in 4 parts: - ethdev API - igb implementation - ixgbe implementation - testpmd Thanks -- Thomas