Hi Thomas, On 02/04/2014 04:54 PM, Thomas Monjalon wrote: > MEMNIC doc may be installed with other DPDK docs. > So more descriptive naming is required. > > A rule is created in order to have the same rule style for lib and doc. > > Signed-off-by: Thomas Monjalon<thomas.monjalon at 6wind.com> > --- > pmd/Makefile | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/pmd/Makefile b/pmd/Makefile > index 7f96af1..1e24a15 100644 > --- a/pmd/Makefile > +++ b/pmd/Makefile
[...] > +install : $(DESTDIR)$(docdir)/$(DOC) > +$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst > + install -D -m 644 $< $@ > + What about renaming README.rst in dpdk-memnic.rst in source ? The rest of the patch looks good to me. Reviewed-by: Olivier Matz <olivier.matz at 6wind.com>
