Hi Neil, Just a couple of minor comments.
> From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Saturday, December 20, 2014 9:02 PM > Subject: [PATCH 1/4] compat: Add infrastructure to support symbol > versioning > > Add initial pass header files to support symbol versioning. > [...] > > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..2299cbe 100644 > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -40,8 +40,12 @@ VPATH += $(SRCDIR) > > ifeq ($(RTE_BUILD_SHARED_LIB),y) > LIB := $(patsubst %.a,%.so,$(LIB)) > + > +CPU_LDFLAGS += --version-script=$(EXPORT_MAP) What about setting --version-script=$(SRCDIR)/$(EXPORT_MAP) so we can do: Ie. 'EXPORT_MAP = rte_eal_version.map' instead of 'EXPORT_MAP = $(RTE_SDK)/lib/librte_eal/linuxapp/eal/rte_eal_version.map' > + > endif > > + > _BUILD = $(LIB) > _INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) > $(RTE_OUTPUT)/lib/$(LIB) _CLEAN = doclean @@ -161,7 +165,9 @@ endif > $(RTE_OUTPUT)/lib/$(LIB): $(LIB) > @echo " INSTALL-LIB $(LIB)" > @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib > +ifneq ($(LIB),) > $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib > +endif > We could move the ifneq($(LIB),) to the _INSTALL variable (top of the same file). Something like this: -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/lib/$(LIB) +_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) +ifneq ($(LIB),) +_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) +endif Thanks, Sergio > # > # Clean all generated files > -- > 1.9.3
