2014-12-18 09:41, Daniel Mrzyglod:
> In test_sched, we are missing NULL pointer checks after calls to create the
> mempool and to allocate an mbuf. Add in these checks using VERIFY macros.
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com>
> ---
> app/test/test_sched.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test/test_sched.c b/app/test/test_sched.c
> index c957d80..9b6e037 100644
> --- a/app/test/test_sched.c
> +++ b/app/test/test_sched.c
> @@ -166,6 +166,7 @@ test_sched(void)
> int err;
>
> mp = create_mempool();
> + VERIFY(mp != NULL,"Error create mempool\n");
A space is missing after the comma.
Is "Error creating mempool" more correct?
> port_param.socket = 0;
> port_param.rate = (uint64_t) 10000 * 1000 * 1000 / 8;
> @@ -184,6 +185,7 @@ test_sched(void)
>
> for (i = 0; i < 10; i++) {
> in_mbufs[i] = rte_pktmbuf_alloc(mp);
> + VERIFY(in_mbufs[i] != NULL, "Bad packet allocation");
An \n is missing.
"Packet allocation failed" seems more appropriate.
--
Thomas
