2014-12-10 03:48, Jincheng Miao: > > It seems you forgot to include the new compat.h. > > > > Did you do some tests with different Fedora/RHEL versions? > > Yes, missing compat.h in kni_vhost.c. > > > And, I want to get your opinion about adding compat.h to kni and xen_dom0. > The pros: easy to implement and minimal wrapper for older kernel.
Yes I think it's the good approach. > The cons: there is so many compat.h, and the file kcompat.h also makes user > confuse. Why kcompat makes user confuse? Do you think you could send a new version quickly to integrate it in the next RC (probably today)? Please test it with RHEL. Thanks -- Thomas