> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, December 4, 2014 6:39 PM > To: Chen, Jing D > Cc: dev at dpdk.org; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug > > 2014-12-04 10:30, Chen, Jing D: > > As I don't know what commit he is based on, I'd like to generate a new > patch with latest dpdk repo. > > There's something wrong here. You rework a patch and you don't know what > was the current status but you expect that the reviewers can understand it > better than you?
You don't understand me. Please read my above words again. As I said, he is in vacation, I came to fix problem. I know exactly what's the problem. So, I used simple way. > You are breaking all the elementary rules of patch management. Please kindly list all the elementary rules of patch management, please. If possible, can you post it somewhere so other new guys can find and follow? > We have currently 2 fixes pending for the same bug. > > PS: please don't top post. I apologized for top post. > > -- > Thomas > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > Sent: Thursday, December 04, 2014 6:26 PM > > > To: Chen, Jing D > > > Cc: dev at dpdk.org; Qiu, Michael > > > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug > > > > > > 2014-12-04 10:18, Qiu, Michael: > > > > Hi Mark, > > > > > > > > I think Huawei (huawei.xie at intel.com) has one patch set to fix this > issue. > > > > > > > > If your patch is totally different with him: > > > > > > > > [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix > > > > > > > > please ignore my comments :) > > > > > > > > But you both calculation are different. > > > > > > Yes, please Jing (Mark), if you reworked the v4 patch, it would > > > clearer to have a changelog, to name it v5 and to insert it in the > > > previous thread with --in-reply-to. > > > At the moment, both patches block each other. > > > > > > -- > > > Thomas
