Hi, > Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master > lcore id > > 2014-07-23 08:53, Hiroshi Shimamoto: > > 2014-07-23 09:50, Thomas Monjalon: > > > 2014-07-22 23:40, Hiroshi Shimamoto: > > > > does anyone have interest in this functionality? > > > > > > > > I think this is important and useful. > > > > Since we should care about core assignment to get high performance > > > > and the master lcore thread is special in DPDK, we will want to > > > > assign the master to the target core. > > > > For example, with hyperthreading I'd like to make a pair of packet > > > > processing threads into one physical core and separate the master > > > > thread which does some management. > > > > > > Thank you for showing your interest. > > > Does it mean you carefully reviewed this patch? In this case, I'd > > > appreciate > > > a note "Reviewed-by:". > > > > Not yet deeply, wait a bit, we're testing this patch in our application. > > Will report if it works fine.
Sorry a delay, I had confirmed the functionality. I'm fine to add Reviewed-by: Hiroshi Shimamoto <h-shimamoto at ct.jp.nec.com> thanks, Hiroshi > > > > By the way, we should add the same code into the BSD code, right? > > Right. > I'd prefer to reduce the duplicated footprint and have more common code > between BSD and Linux. But waiting this enhancement, we have to maintain > the duplicated code for BSD. > > -- > Thomas
