On Wed, Apr 16, 2014 at 09:02:04AM -0400, Neil Horman wrote: > On Wed, Apr 16, 2014 at 01:40:19PM +0200, Thomas Monjalon wrote: > > 2014-04-16 07:02, Neil Horman: > > > On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > > > > 2014-04-15 14:05, Neil Horman: > > > > > This happens automatically on dyanmic linking, but when linking an > > > > > archive > > > > > we need to to include the whole archive to make sure we call all the > > > > > constructors. Not doing this causes them to be discarded due to the > > > > > fact > > > > > theres no symbolic reference connecting the pmds to the application. > > > > > > > > > > Signed-off-by: Neil Horman <nhorman at tuxdriver.com> > > > > > > > > This patch conflicts with Olivier's one: > > > > http://dpdk.org/browse/dpdk/commit/?id=20afd76a504155e947 > > > > > > How does it conflict? I've got it in my dpdk tree here, based off commit > > > 396b69e56a3462ff80537deccebcdecb2771d8ca, which includes Oliviers patch, > > > and > > > mine is applied on top of it cleanly. > > > > It's not a git conflict. > > I mean --whole-archive is set twice. > > Maybe that your patch is not needed. > > > Yeah, I think you're right, its can probably just be dropped. Let me test > quick > and I'll confirm > Neil > Confirmed, its redundant. You can just drop this one patch. Thanks Neil
> > -- > > Thomas > > >
