[dpdk-dev] [PATCH 10/22] app: fix config crash in testpmd

[Thomas Monjalon]

From: Damien Millescamps <damien.millesca...@6wind.com>

A chained topology must always have an increment of 1.
Here, it was 2 if ports number is even.

Acked-by: Ivan Boule <ivan.boule at 6wind.com>
Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
Signed-off-by: Damien Millescamps <damien.millescamps at 6wind.com>
---
 app/test-pmd/config.c |   20 +++++++++-----------
 1 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 10cf699..708ebad 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2,6 +2,7 @@
  *   BSD LICENSE
  * 
  *   Copyright(c) 2010-2012 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2012-2013 6WIND.
  *   All rights reserved.
  * 
  *   Redistribution and use in source and binary forms, with or without 
@@ -547,17 +548,14 @@ simple_fwd_config_setup(void)
        portid_t j;
        portid_t inc = 2;

-       if (nb_fwd_ports % 2) {
-               if (port_topology == PORT_TOPOLOGY_CHAINED) {
-                       inc = 1;
-               }
-               else {
-                       printf("\nWarning! Cannot handle an odd number of ports 
"
-                              "with the current port topology. Configuration "
-                              "must be changed to have an even number of 
ports, "
-                              "or relaunch application with "
-                              "--port-topology=chained\n\n");
-               }
+       if (port_topology == PORT_TOPOLOGY_CHAINED) {
+               inc = 1;
+       } else if (nb_fwd_ports % 2) {
+               printf("\nWarning! Cannot handle an odd number of ports "
+                      "with the current port topology. Configuration "
+                      "must be changed to have an even number of ports, "
+                      "or relaunch application with "
+                      "--port-topology=chained\n\n");
        }

        cur_fwd_config.nb_fwd_ports = (portid_t) nb_fwd_ports;
-- 
1.7.2.5