Gabriel39 commented on PR #435: URL: https://github.com/apache/doris-thirdparty/pull/435#issuecomment-6967849198
Re-review of `1b7c250`: the P1 reported in [my earlier comment](https://github.com/apache/doris-thirdparty/pull/435#issuecomment-6967335487) is resolved. I found no new blocking issues in this revision. I reran the failure/retry scenario with the same runtime combination that exposed the previous problem. The previous binary still times out after catching the first load failure; the new revision completes the retry successfully. The new mutex protects both the loaded flag and publication of Metadata, and exceptional exits leave the state retryable. Validation of this revision: - 120 selected reader/predicate ASAN tests passed. - Both shared-statistics tests passed for 50 repetitions with the previously affected runtime, including injected read and protobuf parse failures. - The additional compressed-Metadata retry test and all 45 valid intervals of an eight-stripe fixture with mixed pruning decisions passed. The downstream integration remains pending in apache/doris#70664 at `add70a4`, as the updated PR description now states. This review did not run TSAN or validate a running Doris BE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
