ixtza commented on code in PR #92:
URL:
https://github.com/apache/doris-kafka-connector/pull/92#discussion_r3380917683
##########
src/main/java/org/apache/doris/kafka/connector/converter/RecordService.java:
##########
@@ -145,14 +148,9 @@ private static boolean isSchemaChange(SinkRecord record) {
private void checkAndApplyTableChangesIfNeeded(
String tableName, RecordDescriptor recordDescriptor) {
if (!hasTable(tableName)) {
- // TODO Table does not exist, lets attempt to create it.
- LOG.warn("The {} table does not exist, please create it
manually.", tableName);
- throw new DorisException(
- "The " + tableName + " table does not exist, please create
it manually.");
- } else {
- // Table exists, lets attempt to alter it if necessary.
- alterTableIfNeeded(tableName, recordDescriptor);
+ schemaCreationManager.createTable(tableName, recordDescriptor);
}
+ alterTableIfNeeded(tableName, recordDescriptor);
}
Review Comment:
solved via
https://github.com/apache/doris-kafka-connector/pull/92/changes#r3380915336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
