Copilot commented on code in PR #373:
URL: https://github.com/apache/doris-thirdparty/pull/373#discussion_r2682438770
##########
driver/others/dynamic.c:
##########
@@ -803,7 +803,27 @@ static gotoblas_t *get_coretype(void){
openblas_warning(FALLBACK_VERBOSE, NEHALEM_FALLBACK);
return &gotoblas_NEHALEM; //OS doesn't support AVX. Use old kernels.
}
- }
+ }
+ return NULL;
+ case 12:
+ // Emerald Rapids (e.g., Intel Xeon Platinum 8575C, model 207 =
exmodel 12, model 15)
+ if (model == 15) {
+ if(support_amx_bf16())
+ return &gotoblas_SAPPHIRERAPIDS;
+ if(support_avx512_bf16())
+ return &gotoblas_COOPERLAKE;
+ if (support_avx512())
+ return &gotoblas_SKYLAKEX;
+ if(support_avx2())
Review Comment:
Model 10 (Meteor Lake) is handled redundantly. It's already included in the
check at line 794 (model == 7 || model == 0), but this separate check for model
== 10 at line 807 has different behavior - it doesn't check for AVX512 support
like line 795 does. This could lead to suboptimal kernel selection for Meteor
Lake processors with AVX512 support. Consider removing this redundant check or
consolidating the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
