zzzxl1993 commented on code in PR #242:
URL: https://github.com/apache/doris-thirdparty/pull/242#discussion_r1799010998


##########
src/core/CLucene/index/IndexWriter.cpp:
##########
@@ -1308,20 +1309,36 @@ void 
IndexWriter::indexCompaction(std::vector<lucene::store::Directory *> &src_d
     }
     assert(readers.size() == numIndices);
 
-    // check hasProx
+    // check hasProx, indexVersion
     bool hasProx = false;
+    IndexVersion indexVersion = IndexVersion::kV1;
     {
         if (!readers.empty()) {
+            auto release_readers = [this]() {

Review Comment:
   Release memory in the try->catch->finally code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to