I agree. When we implement a feature or refactor some code, usually common modules would be modified, e.g. meta and io. There are some rules and common considerations in a module, which we can list in text and some developers do well at some modules. It is good for code quality and efficiency that the code modifying a module is reviewed by a developer who is very familiar with the module.
I propose meta, io, metaservice as modules to follow the proposal. On Tue, Mar 19, 2024 at 6:18 PM 曹亮 <245623...@qq.com.invalid> wrote: > Dear Apache Doris Community, > I am writing to propose the introduction of Maintainer Review for some > core modules in Apache Doris. > Background > > Apache Doris has grown into a powerful, complex, and large-scale project. > With the continuous growth of the codebase, it has become increasingly > difficult to maintain and manage. > > Proposal > > To address the above issues, I propose to introduce Maintainer Review for > some core modules in Apache Doris. This means that code can only be merged > into these modules after it has been reviewed and approved by the > maintainer of the module. > > Benefits > > Introducing Maintainer Review can bring the following benefits: > > Improve code quality > Ensure consistent code style > Strengthen control over core modules > Reduce the workload of maintainers > Implementation Plan > > We can include the following modules in the scope of Maintainer Review: > > Planner > Storage > Catalog > For other modules, we can gradually introduce Maintainer Review as needed. > > Conclusion > > I believe that introducing Maintainer Review will help to improve the code > quality and maintenance efficiency of Apache Doris. I look forward to > hearing your comments and suggestions. > > Additional arguments: > > Introducing Maintainer Review can help us better follow Apache's code > submission guidelines. > Maintainer Review can help us discover and fix code defects faster. > Maintainer Review can help us better Apache Doris' code. > I believe that by introducing Maintainer Review, we can make Apache Doris > a more powerful, reliable, and maintainable project. > > Addressing concerns: > > Maintainer unavailability: We can establish a secondary maintainer or a > backup plan for each module to address the situation when the maintainer is > unavailable. > Maintainer selection: We can call on PMC members and committers in the > community to take on the role of maintainers. They have a deep > understanding of the code and are familiar with the development process. > Call to action: > > I encourage all community members to discuss this proposal and share their > thoughts. We can work together to make Apache Doris a better project. > Thank you! > > BW! > LIANG > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > For additional commands, e-mail: dev-h...@doris.apache.org > >
