here is my +1 (non-binding) I checked: [x] The download link is legal and the PGP signature are valid. [x] The source code matches the current release version. [x] The LICENSE and NOTICE files are correct.
dujunling dujlm...@gmail.com Mingyu Chen <morning...@163.com> 于2022年12月5日周一 16:10写道： > Hi Yang, > Thanks for your review. > As we discussed, this is a bug when loading parquet file to some array > type. > I think we can create an issue to trace this bug, and fix it in next > release soon. > And we already had a bunch of known issues here[1], we can not waiting to > fix all issues before releasing. > > > How do you think about it? > > > [1] > https://github.com/apache/doris/pulls?q=is%3Aopen+is%3Apr+label%3Adev%2F1.2.1 > > > > -- > > 此致！Best Regards > 陈明雨 Mingyu Chen > > Email: > morning...@apache.org > > > > > > 在 2022-12-05 13:02:39，"zhg yang" <yangz...@gmail.com> 写道： > >I found a coredump when loading parquet file into doris, I think it's > >better to resolve this before release this version > > > > > >Thanks > >Yang Zhengguo > > > > > >junling du <dujlm...@gmail.com> 于2022年12月5日周一 11:30写道： > > > >> here is my -1 (non-binding) > >> > >> I checked: > >> [-1] The KEYS file download link is invalid. > >> It should be https://downloads.apache.org/doris/KEYS > >> <https://downloads.apache.org/incubator/doris/KEYS> ? > >> [x] The source code matches the current release version. > >> [x] The LICENSE and NOTICE files are correct. > >> > >> dujunling > >> dujlm...@gmail.com > >> > >> De Li <l...@apache.org> 于2022年12月5日周一 09:09写道： > >> > >> > Where I can find the source tar package? > >> > It seems not in the URL of > >> > https://dist.apache.org/repos/dist/dev/doris/1.2.0-rc04/. > >> > > >> > ----- > >> > lide > >> > l...@apache.org > >> > > >> > > >> > On 2022/12/04 07:47:49 Mingyu Chen wrote: > >> > > Hi all, > >> > > > >> > > > >> > > > >> > > > >> > > Please review and vote on Apache Doris 1.2.0-rc04 release. > >> > > In rc04, we fix a meta persiste bug found in rc03. > >> > > > >> > > > >> > > > >> > > > >> > > The release candidate has been tagged in GitHub as 1.2.0-rc04, > >> available > >> > here: > >> > > > >> > > https://github.com/apache/doris/releases/tag/1.2.0-rc04 > >> > > > >> > > > >> > > > >> > > > >> > > This is a BIG release with tremendous features and improvements. > >> > > > >> > > Release Notes are here: > >> > > > >> > > https://github.com/apache/doris/issues/14461 > >> > > > >> > > > >> > > > >> > > > >> > > Thanks to everyone who has contributed to this release. > >> > > > >> > > > >> > > > >> > > > >> > > The artifacts (source, binary, signature and checksum) > corresponding to > >> > this release > >> > > > >> > > candidate can be found here: > >> > > > >> > > https://dist.apache.org/repos/dist/dev/doris/1.2.0-rc04/ > >> > > > >> > > > >> > > > >> > > > >> > > This has been signed with PGP key F05B15ED, corresponding to > >> > > > >> > > morning...@apache.org. > >> > > > >> > > > >> > > > >> > > > >> > > KEYS file is available here: > >> > > > >> > > https://downloads.apache.org/incubator/doris/KEYS > >> > > > >> > > It is also listed here: > >> > > > >> > > https://people.apache.org/keys/committer/morningman.asc > >> > > > >> > > > >> > > > >> > > > >> > > To verify and build, you can refer to following link: > >> > > > >> > > > https://doris.apache.org/community/release-and-verify/release-verify > >> > > > >> > > > >> > > > >> > > > >> > > The vote will be open for at least 72 hours. > >> > > > >> > > > >> > > > >> > > > >> > > [ ] +1 Approve the release > >> > > > >> > > [ ] +0 No opinion > >> > > > >> > > [ ] -1 Do not release this package because ... > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > -- > >> > > > >> > > 此致！Best Regards > >> > > 陈明雨 Mingyu Chen > >> > > > >> > > Email: > >> > > morning...@apache.org > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > >> > For additional commands, e-mail: dev-h...@doris.apache.org > >> > > >> > > >> >
