+1 Since this code is relatively early, and everyone is using the v2 version now, it can be removed. In order to prepare users for the v1->v2 conversion, it can be explained in advance when this version is released. We will Remove this part of the code in the next version, so everyone is ready.
jiafeng.Zhang / 张家锋 Email：jiafengzh...@apache.org GuoLei Yi <yiguo...@gmail.com>于2022年6月25日 周六20:01写道： > Hi guys, > > I want to remove AlphaRowset or Segment V1 related code because : > 1. Many optimizations like vectorization or low cardinality. > 2. New types is not implemented in segment v1 such as array type, json > type, date v2 or decimal v3. > 3. We need modify alpha rowset related code when we modify vectorization > code like predicate. It is very hard to maintain these code. > > We have already add checks and auto conversions in doris 1.1. Could refer > this issue https://github.com/apache/doris/issues/8984. > > Any advice is appreciated. > > -- > 衣国垒 > SelectDB > Tel:134-3991-0228 > Email:yiguo...@gmail.com > -- 张家峰
