[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #8748: [Bug] fix some error on build.sh && fix build fail with clang on runtime_profile

Sun, 03 Apr 2022 21:31:05 -0700 


BiteTheDDDDt commented on code in PR #8748:
URL: https://github.com/apache/incubator-doris/pull/8748#discussion_r841358132


##########
build.sh:
##########
@@ -135,7 +135,7 @@ if [ $# == 1 ] ; then
     BUILD_FE=1
     BUILD_BE=1
     BUILD_BROKER=1
-    BUILD_META_TOOL=1

Review Comment:
   > why change value from 1 to on here?
   
   to apapt cmakelist
   ```
   if (BUILD_META_TOOL AND BUILD_META_TOOL STREQUAL "ON")
       add_subdirectory(${SRC_DIR}/tools)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to