should we mention developer how to prepare complile env with thrift?


---Original---
From: "??????"<morning...@163.com&gt;
Date: Thu, Feb 24, 2022 12:45 PM
To: "dev"<dev@doris.apache.org&gt;;
Subject: Re:Re: [VOTE] Release Flink Connectors v1.0.2 for Apache 
Doris(Incubating)


&gt;&nbsp;1.&nbsp;We&nbsp;need&nbsp;to&nbsp;add&nbsp;how&nbsp;to&nbsp;build&nbsp;in&nbsp;the&nbsp;README
&gt;&nbsp;2.&nbsp;Need&nbsp;to&nbsp;mention&nbsp;installation&nbsp;of&nbsp;thrift&nbsp;first
&gt;&nbsp;3.&nbsp;We&nbsp;don't&nbsp;need&nbsp;to&nbsp;sign&nbsp;the&nbsp;kit&nbsp;when&nbsp;using&nbsp;mvn&nbsp;clean&nbsp;install&nbsp;by
&gt;&nbsp;default,&nbsp;we&nbsp;can&nbsp;add&nbsp;a&nbsp;release&nbsp;profile&nbsp;for&nbsp;signing&nbsp;the&nbsp;kit.

OK,&nbsp;we&nbsp;will&nbsp;address&nbsp;them&nbsp;before&nbsp;next&nbsp;release.

--

??????Best&nbsp;Regards
??????&nbsp;Mingyu&nbsp;Chen

Email:
chenmin...@apache.org





At&nbsp;2022-02-24&nbsp;11:02:54,&nbsp;"Willem&nbsp;Jiang"&nbsp;<willem.ji...@gmail.com&gt;&nbsp;wrote:
&gt;+1.
&gt;I&nbsp;checked&nbsp;the&nbsp;License&nbsp;and&nbsp;Notice&nbsp;file
&gt;There&nbsp;is&nbsp;no&nbsp;binary&nbsp;in&nbsp;the&nbsp;source&nbsp;release&nbsp;kit.
&gt;We&nbsp;have&nbsp;the&nbsp;incubating&nbsp;disclarm&nbsp;in&nbsp;the&nbsp;source&nbsp;file.
&gt;I&nbsp;finally&nbsp;built&nbsp;the&nbsp;binary&nbsp;from&nbsp;the&nbsp;source&nbsp;kit&nbsp;in&nbsp;my&nbsp;macbook&nbsp;pro.
&gt;
&gt;There&nbsp;are&nbsp;some&nbsp;things&nbsp;we&nbsp;can&nbsp;do&nbsp;before&nbsp;the&nbsp;next&nbsp;release.
&gt;1.&nbsp;We&nbsp;need&nbsp;to&nbsp;add&nbsp;how&nbsp;to&nbsp;build&nbsp;in&nbsp;the&nbsp;README
&gt;2.&nbsp;Need&nbsp;to&nbsp;mention&nbsp;installation&nbsp;of&nbsp;thrift&nbsp;first
&gt;3.&nbsp;We&nbsp;don't&nbsp;need&nbsp;to&nbsp;sign&nbsp;the&nbsp;kit&nbsp;when&nbsp;using&nbsp;mvn&nbsp;clean&nbsp;install&nbsp;by
&gt;default,&nbsp;we&nbsp;can&nbsp;add&nbsp;a&nbsp;release&nbsp;profile&nbsp;for&nbsp;signing&nbsp;the&nbsp;kit.
&gt;
&gt;Willem&nbsp;Jiang
&gt;
&gt;Twitter:&nbsp;willemjiang
&gt;Weibo:&nbsp;????willem
&gt;
&gt;On&nbsp;Tue,&nbsp;Feb&nbsp;22,&nbsp;2022&nbsp;at&nbsp;11:43&nbsp;AM&nbsp;??????&nbsp;<morning...@163.com&gt;&nbsp;wrote:
&gt;&gt;
&gt;&gt;&nbsp;Hi&nbsp;All,
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;This&nbsp;is&nbsp;a&nbsp;call&nbsp;for&nbsp;vote&nbsp;to&nbsp;release&nbsp;Flink&nbsp;Connectors&nbsp;v1.0.2&nbsp;for&nbsp;Apache&nbsp;Doris(Incubating).
&gt;&gt;
&gt;&gt;&nbsp;There&nbsp;are&nbsp;4&nbsp;outputs&nbsp;for&nbsp;different&nbsp;Flink&nbsp;versions:
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;-&nbsp;apache-doris-flink-connector-1.11.6-2.12-1.0.2-incubating
&gt;&gt;
&gt;&gt;&nbsp;-&nbsp;apache-doris-flink-connector-1.12.7-2.12-1.0.2-incubating
&gt;&gt;
&gt;&gt;&nbsp;-&nbsp;apache-doris-flink-connector-1.13.5-2.12-1.0.2-incubating
&gt;&gt;&nbsp;-&nbsp;apache-doris-flink-connector-1.14.3-2.12-1.0.2-incubating
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;This&nbsp;is&nbsp;the&nbsp;first&nbsp;version&nbsp;of&nbsp;flink&nbsp;connector,&nbsp;and&nbsp;1.0.2&nbsp;is&nbsp;used&nbsp;because&nbsp;we&nbsp;have&nbsp;used&nbsp;versions&nbsp;1.0.0&nbsp;and&nbsp;1.0.1&nbsp;for&nbsp;pre-release&nbsp;before,&nbsp;and&nbsp;these&nbsp;2&nbsp;versions&nbsp;are&nbsp;deprecated.
&gt;&gt;&nbsp;We&nbsp;have&nbsp;just&nbsp;moved&nbsp;the&nbsp;code&nbsp;from[1]&nbsp;to&nbsp;[2].
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;The&nbsp;release&nbsp;candidates:
&gt;&gt;
&gt;&gt;&nbsp;https://dist.apache.org/repos/dist/dev/incubator/doris/flink-connector/1.0.2/
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;Maven&nbsp;2&nbsp;staging&nbsp;repository:
&gt;&gt;
&gt;&gt;&nbsp;https://repository.apache.org/content/repositories/orgapachedoris-1004/org/apache/doris/doris-flink-connector/
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;Git&nbsp;tag&nbsp;for&nbsp;the&nbsp;release:
&gt;&gt;
&gt;&gt;&nbsp;https://github.com/apache/incubator-doris-flink-connector/tree/1.11.6-2.12-1.0.2
&gt;&gt;
&gt;&gt;&nbsp;https://github.com/apache/incubator-doris-flink-connector/tree/1.12.7-2.12-1.0.2
&gt;&gt;
&gt;&gt;&nbsp;https://github.com/apache/incubator-doris-flink-connector/tree/1.13.5-2.12-1.0.2
&gt;&gt;&nbsp;https://github.com/apache/incubator-doris-flink-connector/tree/1.14.3-2.12-1.0.2
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;Keys&nbsp;to&nbsp;verify&nbsp;the&nbsp;Release&nbsp;Candidate:
&gt;&gt;
&gt;&gt;&nbsp;https://downloads.apache.org/incubator/doris/KEYS
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;Look&nbsp;at&nbsp;here&nbsp;for&nbsp;how&nbsp;to&nbsp;verify&nbsp;this&nbsp;release&nbsp;candidate:
&gt;&gt;
&gt;&gt;&nbsp;http://doris.incubator.apache.org/community/release-and-verify/release-verify.html
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;The&nbsp;vote&nbsp;will&nbsp;be&nbsp;open&nbsp;for&nbsp;at&nbsp;least&nbsp;72&nbsp;hours&nbsp;or&nbsp;until&nbsp;necessary&nbsp;number&nbsp;of&nbsp;votes&nbsp;are&nbsp;reached.
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;Please&nbsp;vote&nbsp;accordingly:
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;[&nbsp;]&nbsp;+1&nbsp;approve
&gt;&gt;
&gt;&gt;&nbsp;[&nbsp;]&nbsp;+0&nbsp;no&nbsp;opinion
&gt;&gt;
&gt;&gt;&nbsp;[&nbsp;]&nbsp;-1&nbsp;disapprove&nbsp;with&nbsp;the&nbsp;reason
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;[1]&nbsp;https://github.com/apache/incubator-doris
&gt;&gt;
&gt;&gt;&nbsp;[2]&nbsp;https://github.com/apache/incubator-doris-flink-connector
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;
&gt;&gt;&nbsp;--
&gt;&gt;
&gt;&gt;&nbsp;??????Best&nbsp;Regards
&gt;&gt;&nbsp;??????&nbsp;Mingyu&nbsp;Chen
&gt;&gt;
&gt;&gt;&nbsp;Email:
&gt;&gt;&nbsp;chenmin...@apache.org
&gt;
&gt;---------------------------------------------------------------------
&gt;To&nbsp;unsubscribe,&nbsp;e-mail:&nbsp;dev-unsubscr...@doris.apache.org
&gt;For&nbsp;additional&nbsp;commands,&nbsp;e-mail:&nbsp;dev-h...@doris.apache.org

Reply via email to