Actually they do share some interfeces and thrift definition. If these interfaces change, we need to update both connectors. So I suggest to put them in same repo, for easy developing.
-- 此致！Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org 在 2022-02-11 15:05:17，"Willem Jiang" <willem.ji...@gmail.com> 写道： >How about separating these two connectors into two repos, if these >connectors don't share anything in common. > >Willem Jiang > >Twitter: willemjiang >Weibo: 姜宁willem > >On Fri, Feb 11, 2022 at 11:25 AM 陈明雨 <morning...@163.com> wrote: >> >> I tried this way. >> But what we need is to merge the 2 subdirs: >> "extension/flink-doris-connector" and "extension/spark-doris-connector", >> into a new repository. >> This does not seem to be possible with this approach. >> >> >> >> >> >> -- >> >> 此致！Best Regards >> 陈明雨 Mingyu Chen >> >> Email: >> chenmin...@apache.org >> >> >> >> >> >> 在 2022-02-10 23:16:21，"Willem Jiang" <willem.ji...@gmail.com> 写道： >> >Not sure if this link[1] can help you. >> >[1] >> >https://ao.ms/how-to-split-a-subdirectory-to-a-new-git-repository-and-keep-the-history/ >> > >> >Willem Jiang >> > >> >Twitter: willemjiang >> >Weibo: 姜宁willem >> > >> >On Thu, Feb 10, 2022 at 10:31 PM 陈明雨 <morning...@163.com> wrote: >> >> >> >> >Can we keep the commit history of the old code? >> >> >It's not a best practice to commit so big code here. >> >> >> >> Sorry I don't know how to keep the commit history of the connector's code >> >> separately, it's mixed with the commits of Doris' main code. >> >> If I merge the all commit history of the Doris' main code into this new >> >> repository, the repository will become as large as the trunk code base. >> >> >> >> -- >> >> >> >> 此致！Best Regards >> >> 陈明雨 Mingyu Chen >> >> >> >> Email: >> >> chenmin...@apache.org >> >> >> >> >> >> >> >> >> >> >> >> At 2022-02-10 21:21:38, "Willem Jiang" <willem.ji...@gmail.com> wrote: >> >> >Can we keep the commit history of the old code? >> >> >It's not a best practice to commit so big code here. >> >> > >> >> > >> >> >On Thu, Feb 10, 2022 at 2:52 PM <morning...@apache.org> wrote: >> >> >> >> >> >> This is an automated email from the ASF dual-hosted git repository. >> >> >> >> >> >> morningman pushed a commit to branch master >> >> >> in repository >> >> >> https://gitbox.apache.org/repos/asf/incubator-doris-manager.git >> >> >> >> >> >> commit b82a5edbcec201b1dcfe1c6937ffc9325a8f17a1 >> >> >> Author: morningman <chenmin...@baidu.com> >> >> >> AuthorDate: Thu Feb 10 14:43:40 2022 +0800 >> >> >> >> >> >> [init] init commit >> >> >> >> >> >> Move manager code from >> >> >> https://github.com/apache/incubator-doris/tree/doris-manager@4a22750 >> >> >> --- >> >> >> .asf.yaml | 40 + >> >> >> .github/ISSUE_TEMPLATE/bug_report.yml | 109 ++ >> >> >> .github/ISSUE_TEMPLATE/config.yml | 23 + >> >> >> .github/ISSUE_TEMPLATE/enhancement.yml | 76 ++ >> >> >> .github/ISSUE_TEMPLATE/feature-request.yml | 78 ++ >> >> >> .github/PULL_REQUEST_TEMPLATE.md | 19 + >> >> >> .github/workflows/approve-label-trigger.yml | 28 + >> >> >> .github/workflows/approve-label.yml | 67 ++ >> >> >> .github/workflows/build-extension.yml | 49 + >> >> >> .github/workflows/license-eyes.yml | 35 + >> >> >> .gitignore | 7 + >> >> >> .licenserc.yaml | 36 + >> >> > >> >> >--------------------------------------------------------------------- >> >> >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >> >For additional commands, e-mail: dev-h...@doris.apache.org >> > >> >--------------------------------------------------------------------- >> >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> >For additional commands, e-mail: dev-h...@doris.apache.org > >--------------------------------------------------------------------- >To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >For additional commands, e-mail: dev-h...@doris.apache.org
