imay commented on a change in pull request #1756: Encapsulate HLL logic
URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322044569
##########
File path: be/src/exec/csv_scan_node.cpp
##########
@@ -672,14 +672,14 @@ void CsvScanNode::hll_hash(const char* src, int len,
std::string* result) {
std::string str(src, len);
if (str != "\\N") {
uint64_t hash = HashUtil::murmur_hash64A(src, len,
HashUtil::MURMUR_SEED);
- char buf[HllHashFunctions::HLL_INIT_EXPLICT_SET_SIZE];
+ char buf[10];
Review comment:
We should use a const or a macro, better not to use a magic number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
