imay commented on issue #1753: Use crc32c checksum for segment v2 URL: https://github.com/apache/incubator-doris/pull/1753#issuecomment-528724219 @gaodayue I have two questions about this PR. 1. Even if HashUtils::crc_hash doesn't generate standard CRC-32 checksum, the checksums should be equal. Because all the checksums are compute by this function. 2. we have already had a CRC-32 implementation in `be/src/olap/utils.cpp`. Can you unify this and your new implementation?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
