chaoyli commented on a change in pull request #1722: Use int64 when converting
TIME type value
URL: https://github.com/apache/incubator-doris/pull/1722#discussion_r318919843
##########
File path: be/src/runtime/memory_scratch_sink.cpp
##########
@@ -140,7 +140,7 @@ Status MemoryScratchSink::add_per_col(RuntimeState* state,
TupleRow* row, std::s
break;
case TYPE_TIME: {
double time = *static_cast<double *>(item);
Review comment:
no need to convert to double
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
