morningman commented on a change in pull request #1530: Add more logs and
metrics to trace the broker load process
URL: https://github.com/apache/incubator-doris/pull/1530#discussion_r306288450
##########
File path: be/src/exec/tablet_sink.cpp
##########
@@ -612,8 +616,17 @@ Status OlapTableSink::close(RuntimeState* state, Status
close_status) {
COUNTER_SET(_validate_data_timer, _validate_data_ns);
COUNTER_SET(_wait_in_flight_packet_timer, _wait_in_flight_packet_ns);
COUNTER_SET(_serialize_batch_timer, _serialize_batch_ns);
-
state->update_num_rows_load_filtered(_number_filtered_rows);
+
+ // print log of add batch time of all node, for tracing load
performance easily
+ std::stringstream ss;
+ ss << "finished to close olap table sink. load_id=" <<
print_id(_load_id)
+ << ", txn_id=" << _txn_id << ", node add batch time(ns): ";
+ for (auto const& pair: _node_add_batch_time_map) {
+ ss << "{" << pair.first << "=" << pair.second << "}";
+ }
+ LOG(INFO) << ss.str();
Review comment:
VLOG can not be used online..
I think add one log for one load job is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
