gaodayue commented on a change in pull request #1409: Add dict page
URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305227490
##########
File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h
##########
@@ -170,11 +148,11 @@ class BitshufflePageBuilder : public PageBuilder {
_data.push_back(0);
}
- _buffer.resize(BITSHUFFLE_BLOCK_HEADER_SIZE +
+ _buffer.resize(BITSHUFFLE_PAGE_HEADER_SIZE +
bitshuffle::compress_lz4_bound(num_elems_after_padding,
final_size_of_type, 0));
encode_fixed32_le(&_buffer[0], _count);
- int64_t bytes = bitshuffle::compress_lz4(_data.data(),
&_buffer[BITSHUFFLE_BLOCK_HEADER_SIZE],
+ uint32_t bytes = bitshuffle::compress_lz4(_data.data(),
&_buffer[BITSHUFFLE_PAGE_HEADER_SIZE],
Review comment:
bitshuffle::compress_lz4 returns negative number on error, therefore return
type should be int64_t
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
