imay commented on a change in pull request #1432: Add percentile_approx
aggregate function
URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301530690
##########
File path: be/src/exprs/aggregate_functions.cpp
##########
@@ -231,6 +232,84 @@ void AggregateFunctions::avg_update(FunctionContext* ctx,
const T& src, StringVa
++avg->count;
}
+struct PercentileApproxState {
+public:
+ TDigest *digest = nullptr;
+ double targetQuantile = -1.0;
+
+ ~PercentileApproxState() {
+ if (digest != nullptr) {
+ delete digest;
+ }
+ }
+};
+
+void AggregateFunctions::percentile_approx_init(FunctionContext* ctx,
StringVal* dst) {
+ dst->is_null = false;
+ dst->len = sizeof(PercentileApproxState);
+ dst->ptr = (uint8_t*) new PercentileApproxState();
+
+ PercentileApproxState* percentile =
reinterpret_cast<PercentileApproxState*>(dst->ptr);
+ percentile->targetQuantile = -1.0;
+ percentile->digest = new TDigest();
+};
+
+template<typename T>
+void AggregateFunctions::percentile_approx_update(FunctionContext* ctx, const
T& src, const DoubleVal& quantile, StringVal* dst) {
+ if (src.is_null) {
+ return;
+ }
+ DCHECK(dst->ptr != NULL);
+ DCHECK_EQ(sizeof(PercentileApproxState), dst->len);
+
+ PercentileApproxState* percentile =
reinterpret_cast<PercentileApproxState*>(dst->ptr);
+ percentile->digest->add(src.val);
+ percentile->targetQuantile = quantile.val;
+}
+
+StringVal AggregateFunctions::percentile_approx_serialize(FunctionContext*
ctx, const StringVal& src) {
+ DCHECK(!src.is_null);
+
+ PercentileApproxState *percentile =
reinterpret_cast<PercentileApproxState*>(src.ptr);
+ uint32_t serialized_size = percentile->digest->serialized_size();
+ StringVal result(ctx, sizeof(double) + serialized_size);
+ memcpy(result.ptr, &percentile->targetQuantile, sizeof(double));
+ percentile->digest->serialize(result.ptr + sizeof(double));
+
+ delete (PercentileApproxState*) src.ptr;
+ return result;
+}
+
+void AggregateFunctions::percentile_approx_merge(FunctionContext* ctx, const
StringVal& src, StringVal* dst) {
+ DCHECK(dst->ptr != NULL);
+ DCHECK_EQ(sizeof(PercentileApproxState), dst->len);
+
+ double quantile;
+ memcpy(&quantile, src.ptr, sizeof(double));
+
+ PercentileApproxState *src_percentile = new PercentileApproxState();
+ src_percentile->targetQuantile = quantile;
+ src_percentile->digest = new TDigest();
+ src_percentile->digest->unserialize(src.ptr + sizeof(double));
+
+ PercentileApproxState* dst_percentile =
reinterpret_cast<PercentileApproxState*>(dst->ptr);
+ dst_percentile->digest->merge(src_percentile->digest);
+ dst_percentile->targetQuantile = quantile;
+
+ delete src_percentile;
+}
+
+DoubleVal AggregateFunctions::percentile_approx_finalize(FunctionContext* ctx,
const StringVal& src) {
+ DCHECK(!src.is_null);
+
+ PercentileApproxState* percentile = reinterpret_cast<PercentileApproxState
*>(src.ptr);
+ double quantile = percentile->targetQuantile;
+ double result = percentile->digest->quantile(quantile);
+
+ delete (PercentileApproxState*) src.ptr;
Review comment:
```suggestion
delete percentile;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
