imay commented on a change in pull request #1413: Add short key index builder,
decoder, iterator
URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298942713
##########
File path: be/src/olap/olap_index.h
##########
@@ -87,13 +83,11 @@ struct OLAPIndexOffset {
// 唯一标识一个RowBlock在Data文件和Index文件中的位置
struct RowBlockPosition {
Review comment:
We should do this after be_refactor has been merged. And I think we should
do it in anther patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
