gaodayue commented on a change in pull request #1413: Add short key index
builder, decoder, iterator
URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298922286
##########
File path: be/src/olap/olap_index.h
##########
@@ -87,13 +83,11 @@ struct OLAPIndexOffset {
// 唯一标识一个RowBlock在Data文件和Index文件中的位置
struct RowBlockPosition {
Review comment:
It looks like `RowBlockPosition` and `OLAPIndexOffset` are the same thing,
both use (segNum, blockNum) pair to unique identify each row block within a
segment group. Can we combine them into one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
