imay commented on a change in pull request #1361: Check get_header status
returned
URL: https://github.com/apache/incubator-doris/pull/1361#discussion_r296465636
##########
File path: be/src/olap/olap_snapshot.cpp
##########
@@ -718,6 +718,16 @@ OLAPStatus OLAPEngine::storage_medium_migrate(
<< "schema_hash_path=" << schema_hash_path;
remove_all_dir(schema_hash_path);
}
+
+ OLAPHeader* new_olap_header = new(std::nothrow) OLAPHeader();
+ res = OlapHeaderManager::get_header(stores[0], tablet->tablet_id(),
tablet->schema_hash(), new_olap_header);
Review comment:
memory leak for new_olap_header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
