chaoyli commented on a change in pull request #1159: Check _empty when convert
old files or make snapshots
URL: https://github.com/apache/incubator-doris/pull/1159#discussion_r284085854
##########
File path: be/src/olap/olap_snapshot_converter.cpp
##########
@@ -417,6 +420,7 @@ OLAPStatus OlapSnapshotConverter::to_new_snapshot(const
OLAPHeaderMessage& olap_
RETURN_NOT_OK(rowset.init());
std::vector<std::string> success_files;
RETURN_NOT_OK(rowset.convert_from_old_files(old_data_path_prefix,
&success_files));
Review comment:
I think add a judgement in _construct_file_name to handle segment_group_id =
-1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
