morningman commented on a change in pull request #818: Add show proc of routine
load and task
URL: https://github.com/apache/incubator-doris/pull/818#discussion_r269380474
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -985,6 +1007,26 @@ private String jobPropertiesToJsonString() {
abstract String dataSourcePropertiesJsonToString();
+
+ public boolean needRemove() {
+ if (!isFinal()) {
+ return false;
+ }
+ Preconditions.checkState(endTimestamp != -1, endTimestamp);
+ if ((System.currentTimeMillis() - endTimestamp) >
Config.label_clean_interval_second * 1000) {
+ return true;
+ }
+ return false;
+ }
+
+ public boolean isFinal() {
Review comment:
why not just return state.isFinalState()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
