chaoyli commented on a change in pull request #647: Fix bugs of restart
URL: https://github.com/apache/incubator-doris/pull/647#discussion_r258446944
##########
File path: be/src/olap/rowset/alpha_rowset.cpp
##########
@@ -129,13 +129,13 @@ void AlphaRowset::set_version_and_version_hash(Version
version, VersionHash ver
segment_group_pb.set_index_size(segment_group->index_size());
segment_group_pb.set_data_size(segment_group->data_size());
segment_group_pb.set_num_rows(segment_group->num_rows());
- const std::vector<KeyRange>* column_statistics =
&(segment_group->get_column_statistics());
- if (column_statistics != nullptr) {
- for (size_t i = 0; i < column_statistics->size(); ++i) {
+ const std::vector<KeyRange> column_statistics =
segment_group->get_column_statistics();
Review comment:
You should use reference const std::vector<KeyRange>&
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
