chaoyli commented on a change in pull request #588: Add some implementation to
TabletMeta
URL: https://github.com/apache/incubator-doris/pull/588#discussion_r250895063
##########
File path: be/src/olap/tablet.h
##########
@@ -75,10 +75,9 @@ class Tablet : public std::enable_shared_from_this<Tablet> {
OLAPStatus save_tablet_meta();
void delete_expire_incremental_data();
- OLAPStatus publish_version(int64_t transaction_id, Version version,
VersionHash version_hash);
const PDelta* get_incremental_delta(Version version) const;
- OLAPStatus clone_data(const TabletMeta& clone_header,
- const std::vector<const PDelta*>& clone_deltas,
+ OLAPStatus clone_data(const TabletMeta& tablet_meta,
+ const std::vector<RowsetMetaSharedPtr>& clone_deltas,
Review comment:
I will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
