yiguolei commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649764
########## File path: be/src/olap/delta_writer.cpp ########## @@ -113,13 +113,13 @@ OLAPStatus DeltaWriter::init() { .set_rowset_state(PREPARING) .set_txn_id(_req.txn_id) .set_load_id(_req.load_id); - RowsetBuilderContext builder_context = context_builder.build(); + RowsetWriterContext builder_context = context_builder.build(); Review comment: if the class name is RowsetWriter then the param name should be writer_context? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org