chenhao7253886 commented on a change in pull request #531: Add cpu and io 
indicates to audit log
URL: https://github.com/apache/incubator-doris/pull/531#discussion_r247773722
 
 

 ##########
 File path: be/src/service/internal_service.cpp
 ##########
 @@ -54,6 +54,18 @@ void 
PInternalServiceImpl<T>::transmit_data(google::protobuf::RpcController* cnt
             request->be_number(), request->packet_seq(),
             eos ? nullptr : &done);
     }
+
+    if (request->has_query_statistic()) {
 
 Review comment:
   Now add_data is used for add batch,  when eos is true and request does't 
contain batch,  add_data will not be called, but request may contains query 
statistics, so it is more simple to handle query statistics update separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to