kangpinghuang commented on a change in pull request #529: Remove segment group
from delta writer
URL: https://github.com/apache/incubator-doris/pull/529#discussion_r247392934
##########
File path: be/src/olap/delta_writer.cpp
##########
@@ -143,20 +148,7 @@ OLAPStatus DeltaWriter::write(Tuple* tuple) {
_mem_table->insert(tuple);
if (_mem_table->memory_usage() >= config::write_buffer_size) {
- RETURN_NOT_OK(_mem_table->flush(_writer));
-
- ++_segment_group_id;
- //_cur_segment_group = new SegmentGroup(_tablet.get(), false,
_segment_group_id, 0, true,
- // _req.partition_id, _req.transaction_id);
- _cur_segment_group = nullptr;
- DCHECK(_cur_segment_group != nullptr) << "failed to malloc
SegmentGroup";
- _cur_segment_group->acquire();
- _cur_segment_group->set_load_id(_req.load_id);
- _segment_group_vec.push_back(_cur_segment_group);
-
- SAFE_DELETE(_writer);
- _writer = ColumnDataWriter::create(_cur_segment_group, true,
_tablet->compress_kind(), _tablet->bloom_filter_fpp());
- DCHECK(_writer != nullptr) << "memory error occur when creating
writer";
+ RETURN_NOT_OK(_mem_table->flush(_rowset_builder.get()));
Review comment:
OK, I will modify it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
